Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dunning): logic for fetching text (backport #43160) #43489

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 2, 2024

Before

(a). If the language parameter is provided, return the text for this language. If this doesn't exist, return None.
(b.) If the language parameter is not provided, return the text marked as Is Default Language. If this doesn't exist, return None.

After

  1. If the language parameter is provided, return the text for this language.
  2. If doc.language exists, return the text for this language.
  3. If a text marked as Is Default Language exists, return this one.
  4. Return an empty dict (-> uniform return type)

How to test

  1. Create a Dunning Type
    • add texts for different languages, enable Is Default Language for one of them
  2. Create overdue Sales Invoices for customers with different languages
  3. Click on "Create" -> "Dunning" in each Sales Invoice
    This is an automatic backport of pull request fix(Dunning): logic for fetching text #43160 done by Mergify.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Oct 2, 2024
@barredterra barredterra merged commit 31ecdb2 into version-14-hotfix Oct 3, 2024
11 checks passed
@barredterra barredterra deleted the mergify/bp/version-14-hotfix/pr-43160 branch October 3, 2024 19:29
@barredterra barredterra removed the needs-tests This PR needs automated unit-tests. label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant